Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nawm generation based on distance map #1026

Merged
merged 14 commits into from
Oct 11, 2024
Merged

Nawm generation based on distance map #1026

merged 14 commits into from
Oct 11, 2024

Conversation

frheault
Copy link
Member

@frheault frheault commented Sep 4, 2024 •
edited
Loading

Quick description

Script to compute NAWM around a binary lesion mask OR a lesion labels map. This output image(s) that will look like rings around each lesion.
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Sep 4, 2024 •
edited
Loading

Hello @frheault, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-11 15:07:13 UTC

ThoumyreStanislas
ThoumyreStanislas reviewed Sep 5, 2024
View reviewed changes
scripts/scil_lesions_generate_nawm.py Outdated Show resolved Hide resolved
scripts/scil_lesions_generate_nawm.py Show resolved Hide resolved
scripts/scil_lesions_generate_nawm.py Outdated Show resolved Hide resolved
scripts/scil_lesions_generate_nawm.py Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.87952% with 25 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (f690978) to head (2ce4f62).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1026   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files         431      432    +1     
  Lines       22372    22455   +83     
  Branches     3024     3039   +15     
=======================================
+ Hits        15390    15448   +58     
- Misses       5695     5709   +14     
- Partials     1287     1298   +11
Components Coverage Δ
Scripts 69.66% <61.40%> (-0.04%) ⬇️
Library 67.56% <88.46%> (+0.05%) ⬆️

@frheault frheault merged commit a07a8ec into scilus:master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThoumyreStanislas ThoumyreStanislas ThoumyreStanislas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frheault @pep8speaks @ThoumyreStanislas